Post by Capsized on Jun 25, 2019 11:21:43 GMT -6
When did you start the game - 1900 or 1920? irrelevant
What nation were you playing? irrelevant
Were there any start options that were not the default? irrelevant
Describe the issue in detail. see below
What were you doing when the bug occurred? irrelevant
What did you expect to happen and how was the result you saw different than you expected. see below
Can you describe how to reproduce the bug? Yes
What version of the game were you playing (v1.00, v1.01, etc)? 1.05
For all ship types except BB and BC (as far as I can tell), in the .xxd file that define the ship design, the key ASWMortar is duplicated:
There should be only one.
I tested a bit, it looks like only the first one is read. Having "ASWMortar=1" followed by "ASWMortar=0" results in a ship with an ASW mortar according to the design window.
That's reeeeeeeeaaaalllllyyyyy bad for several reasons:
- there is something wrong in the way the game is saving ship design files. Who knows what else is broken by the cause of this bug?
- there is something wrong in the way the game is loading ship files. Is the design window is always reading the first duplicated key, is it also true in the rest of the game? A validated loader should have raised an error. And because the ASW mortar impacts only the strategic game and is hidden behind events with a lot of randomization, it is nearly impossible to test. Is it actually having an effect in game?
- I want to update a small tool I made for RTW1, and this duplicated key is a real problem. The good and proper parser I use is complaining loudly about the duplicated key. If I want to solve this, I will have to write a horrible bodge to read the file "correctly".
What nation were you playing? irrelevant
Were there any start options that were not the default? irrelevant
Describe the issue in detail. see below
What were you doing when the bug occurred? irrelevant
What did you expect to happen and how was the result you saw different than you expected. see below
Can you describe how to reproduce the bug? Yes
What version of the game were you playing (v1.00, v1.01, etc)? 1.05
For all ship types except BB and BC (as far as I can tell), in the .xxd file that define the ship design, the key ASWMortar is duplicated:
There should be only one.
I tested a bit, it looks like only the first one is read. Having "ASWMortar=1" followed by "ASWMortar=0" results in a ship with an ASW mortar according to the design window.
That's reeeeeeeeaaaalllllyyyyy bad for several reasons:
- there is something wrong in the way the game is saving ship design files. Who knows what else is broken by the cause of this bug?
- there is something wrong in the way the game is loading ship files. Is the design window is always reading the first duplicated key, is it also true in the rest of the game? A validated loader should have raised an error. And because the ASW mortar impacts only the strategic game and is hidden behind events with a lot of randomization, it is nearly impossible to test. Is it actually having an effect in game?
- I want to update a small tool I made for RTW1, and this duplicated key is a real problem. The good and proper parser I use is complaining loudly about the duplicated key. If I want to solve this, I will have to write a horrible bodge to read the file "correctly".
